-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add .remove method to deck class (#681) #682
Conversation
…keywords in a deck by indexes
…d proper error handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please include a test?
Good point, sure I will add one. |
… into add-remove-method-to-deck-class
@koubaa I just figured that one can do now deck.remove(...) but on the individual lists e.g. deck.keywords.remove(...) or deck.string_keywords.remove(...) obviously still does not work. Do you think it makes sense to add this functionality as well there or is there already another intended way to to this? |
@RaphaelHeiniger those aren't lists in themselves, those are just filters applied on the main list. I think what you have done in this PR is probably the best we can do. |
Usage: