Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Read parameters #728

Merged
merged 10 commits into from
Feb 18, 2025
Merged

fix: Read parameters #728

merged 10 commits into from
Feb 18, 2025

Conversation

koubaa
Copy link
Collaborator

@koubaa koubaa commented Feb 18, 2025

Partial fix for #641 and #711

Fixes #723

  • Add multi-line include for *INCLUDE_PATH using the same mixin as *INCLUDE. (now filename is used rather than path which is not ideal, but we can look at that later)
  • Support negative parameters using -&
  • *PARAMETER has a 1-dimensional series of parameters, not a table.
  • codegen for series card is moved to its own file (continuing the refactoring to split all of them)
  • Implement an import handler that reads parameters into the keyword deck after importing. This is not yet recursive and doesn't handle the _LOCAL option.

Mohamed Koubaa added 6 commits February 18, 2025 10:18
convert parameters to a struct series card
implement parameter import handler
automatically include parameter handler in deck's
import handler
@koubaa koubaa requested a review from a team as a code owner February 18, 2025 16:35
@koubaa koubaa changed the title Read parameters fix: Read parameters Feb 18, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation testing Anything related to testing labels Feb 18, 2025
@koubaa koubaa linked an issue Feb 18, 2025 that may be closed by this pull request
@koubaa koubaa merged commit bfad0b6 into main Feb 18, 2025
30 checks passed
@koubaa koubaa deleted the read-parameters branch February 18, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling parametrized input decks Multiline INCLUDE_PATH not supported
2 participants