fix: Rework defaults #730
Merged
fix: Rework defaults #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
koubaa
force-pushed
the
rework-defaults
branch
from
8d00d72 to
e921f01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #605
I realized that to handle defaults for tables or series, we should process the defaults using the kwargs.
Right now, defaults for the regular card is done in the constructor of the keyword. We can simplify that by handling defaults in the field constructor, with some minor changes elsewhere to fix issues.
All the generated files were changed. To review the non-generated changes - look at all but the "update codegen" commit.