Fix locally build docs in Windows #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germa89
commented
Sep 15, 2023
|
LGTM. |
Codecov Report
@@ Coverage Diff @@
## main #2338 +/- ##
==========================================
+ Coverage 81.68% 87.61% +5.93%
==========================================
Files 45 45
Lines 8513 8513
==========================================
+ Hits 6954 7459 +505
+ Misses 1559 1054 -505 |
3 tasks
clatapie
reviewed
Sep 25, 2023
| @@ -405,7 +405,7 @@ def solve(self, freq_start, freq_end, freq_steps, ramped_load=True): | |||
|
|
|||
| Returns | |||
| ------- | |||
| AnsMat | |||
| AnsMath | |||
There was a problem hiding this comment.
The AnsMat mention was, in my opinion, not a typo.
The output is supposed to be a matrix.
There was a problem hiding this comment.
This is valid for all the AnsMath mentions in this PR.
AnsMat and AnsVec are AnsMath objects.
There was a problem hiding this comment.
Ohh.. Interesting... I thought it was a typo.
I might undo it in the future.
|
Otherwise, good catch for having located the bug in this file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title.
Routinary work checking PyMAPDL builds locally in windows.
Close #2255