-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: testing suite (random order) #3519
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
0a890bb
to
e206260
Compare
…s/pymapdl into ci/doing-random-tests-on-ci
@germa89 While passing by... Would it make sense for you to use |
Thank you a lot for the suggestion! This is a good idea, and believe we did try it in the pass. The main limitation is that I will have to spin several MAPDL instances which is "heavy" since the docker image is huge. I think that is why we did not implement it. Additionally, so far, our main bottleneck is on the documentation generation where I do want to implement some parallelization technique, probably having more than one MAPDL image. I appreciate a lot you coming around PyMAPDL repo! :) |
…e over clear() calls.
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache in a new commit. This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore you will see the actions showing in their status You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
I knew that changing the order will increase the time... but yisus.... that's a lot. And I think it is just the respawming of the MAPDL what is taking the time.... but I do not have any probe of this. |
for more information, see https://pre-commit.ci
@pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Implementing random order in the testing #GoodPractice.
Additionally, several more issues and changes spawned from this, like:
conftest.py
filecleared
fixture for all the tests running MAPDL.Issue linked
Close #3268
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)