Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docker instructions #3580

Merged
merged 4 commits into from
Nov 27, 2024
Merged

docs: update docker instructions #3580

merged 4 commits into from
Nov 27, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 26, 2024

Description

As the title.

Issue linked

Close #3579

Checklist

@germa89 germa89 requested a review from a team as a code owner November 26, 2024 16:52
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 26, 2024 16:52
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@wiz-inc-572fc38784
Copy link
Contributor

wiz-inc-572fc38784 bot commented Nov 26, 2024

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities
Data Finding Sensitive Data
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations 1 Medium 2 Info
Total 1 Medium 2 Info

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc) labels Nov 26, 2024
@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) and removed documentation Documentation related (improving, adding, etc) labels Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.98%. Comparing base (aad1006) to head (f2b599f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3580   +/-   ##
=======================================
  Coverage   86.98%   86.98%           
=======================================
  Files         187      187           
  Lines       14623    14623           
=======================================
  Hits        12720    12720           
  Misses       1903     1903           

@germa89 germa89 self-assigned this Nov 26, 2024
@germa89 germa89 requested a review from moe-ad November 26, 2024 18:15
@germa89
Copy link
Collaborator Author

germa89 commented Nov 26, 2024

Please @moe-ad can you have a look and see if this PR mitigates your issues?

@germa89
Copy link
Collaborator Author

germa89 commented Nov 27, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89
Copy link
Collaborator Author

germa89 commented Nov 27, 2024

Because @moe-ad is going to test again with WSL and the new docs, let's merge this and we can always edit accordingly.

@germa89 germa89 merged commit 6f2a1d6 into main Nov 27, 2024
41 of 54 checks passed
@germa89 germa89 deleted the docs--update-docker-docs branch November 27, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docker files
2 participants