Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using test class in test_components.py #3664

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 14, 2025

Description

As the title.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner January 14, 2025 20:47
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jan 14, 2025
@github-actions github-actions bot added the enhancement Improve any current implemented feature label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.11%. Comparing base (e33b5a1) to head (8033fb4).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3664      +/-   ##
==========================================
+ Coverage   87.09%   87.11%   +0.01%     
==========================================
  Files         187      187              
  Lines       14694    14694              
==========================================
+ Hits        12798    12800       +2     
+ Misses       1896     1894       -2     

@germa89
Copy link
Collaborator Author

germa89 commented Jan 21, 2025

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) January 21, 2025 09:33
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit cacc150 into main Jan 21, 2025
53 of 54 checks passed
@germa89 germa89 deleted the refactor/component-testing-into-classes branch January 21, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants