feat: aux2 submodule
#3683
Open
feat: aux2 submodule
#3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clatapie
added
documentation
clatapie
requested review from
germa89 and
pyansys-ci-bot
and removed request for
a team
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
CI/CD
github-actions
bot
removed
CI/CD
germa89
approved these changes
Jan 30, 2025
| mass matrix values (and possibly element damping matrix values) are incorporated into the globally | ||
| assembled stiffness matrix. Thus, the globally assembled stiffness matrix represents more than the | ||
| stiffness of the model for these analysis types. Please refer to the `Theory Reference | ||
| <https://ansyshelp.ansys.com/Views/Secured/corp/v232/en/ans_thry/thy_biblio.html>`_ Mechanical APDL |
There was a problem hiding this comment.
I am not following, what are you referring to here?
There was a problem hiding this comment.
I got it now, sorry for the delay 😄
I am investigating!
Comment on lines
+125
to
+126
| files are | ||
| stored by row and not column, when the :ref:`hbmat` command is used with a non-symmetric matrix, the |
Comment on lines
+295
to
+297
| stiffness of the model for these analysis types. Please refer to the `Theory Reference | ||
| <https://ansyshelp.ansys.com/Views/Secured/corp/v232/en/ans_thry/thy_biblio.html>`_ Mechanical APDL | ||
| Theory Reference for more details. |
There was a problem hiding this comment.
Same duplicated Theory Reference
|
Once you have take care of my comments, you can move back the files to their previous locations. Since my comments should not change the code, rather the implementation, you could do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows the PyConverter-XML2Py integration plan to automate the PyMAPDL_commands documentation.
The changes have been generated using pyconverter-xml2py and more specifically mapdl-cmd-conv.
This PR focus on the
aux2submodule.Pinging @ansys/pymapdl-developers for visibility. Feel free to provide any feedback on the way the docstrings and the source code generation are handled.
Issue linked
Note
This PR is meant to be merged within the feat/main_commands branch. The latter will gather all the submodule changes, one by one, prior to be merged to the main branch.
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)