-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aux3
submodule
#3689
base: feat/main_commands
Are you sure you want to change the base?
feat: aux3
submodule
#3689
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into feat/aux3_submodule
|
||
The :ref:`modify` command is valid only in the results file editing processor (auxiliary processor | ||
AUX3), and, like the other AUX3 commands, it only affects the data steps index (DSI), time (TIM), | ||
loadstep, substep and cumulative step iteration (LSP) records in the results file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about the naming convention in MAPDL. Up to you 😃
loadstep, substep and cumulative step iteration (LSP) records in the results file. | |
load step, sub step and cumulative step iteration (LSP) records in the results file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MaxJPRey for your feedback! Unfortunately, the output is automatically generated from the MAPDL documentation with the PyConverter-XML2Py which means that such changes need to be modified directly within the MAPDL documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @MaxJPRey ... for the moment we keep the docs as close as MAPDL docs as possible. Typos should be fixed upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR follows the PyConverter-XML2Py integration plan to automate the PyMAPDL_commands documentation.
The changes have been generated using pyconverter-xml2py and more specifically mapdl-cmd-conv.
This PR focus on the
aux3
submodule.Pinging @ansys/pymapdl-developers for visibility. Feel free to provide any feedback on the way the docstrings and the source code generation are handled.
Issue linked
This PR is meant to be merged within the feat/main_commands branch. The latter will gather all the submodule changes, one by one, prior to be merged to the main branch.
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)