Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plotting): Improve interface of the plotting class. #3702

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented Jan 24, 2025

Description

This PR improves the usability of some methods in the plotting class. This class was meant to be used inside eplot, vplot.. functions, but since some use cases involve using it standalone, I improved it's usability and documentation.

Checklist

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.05%. Comparing base (c943198) to head (dd79733).

❌ Your patch check has failed because the patch coverage (76.47%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3702      +/-   ##
==========================================
- Coverage   88.12%   88.05%   -0.07%     
==========================================
  Files         187      187              
  Lines       14707    14716       +9     
==========================================
- Hits        12960    12958       -2     
- Misses       1747     1758      +11     

@AlejandroFernandezLuces
Copy link
Contributor Author

@clatapie This PR fixes your original issue. I'm unsure if more issues will arise, since plots are not throwing errors and I do not know how plots should look like. I would need to compare results from the original examples to what we have right now for further debugging.

From my point of view, we can either merge this PR and we can add more fixes as issues arise, or you can install this branch in your local and ping me when something does not look as expected. What do you think?

@AlejandroFernandezLuces AlejandroFernandezLuces changed the title fix(plotting): Test plotting changes fix(plotting): Improve interface of the plotting class. Jan 27, 2025
@clatapie
Copy link
Contributor

Thanks for fixing the error @AlejandroFernandezLuces!
I will use this branch in the PyMAPDL-Example PR and check the documentation output so that we will have it tested with a broader range of examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants