-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plotting): Improve interface of the plotting class. #3702
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (76.47%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3702 +/- ##
==========================================
- Coverage 88.12% 88.05% -0.07%
==========================================
Files 187 187
Lines 14707 14716 +9
==========================================
- Hits 12960 12958 -2
- Misses 1747 1758 +11 |
@clatapie This PR fixes your original issue. I'm unsure if more issues will arise, since plots are not throwing errors and I do not know how plots should look like. I would need to compare results from the original examples to what we have right now for further debugging. From my point of view, we can either merge this PR and we can add more fixes as issues arise, or you can install this branch in your local and ping me when something does not look as expected. What do you think? |
Thanks for fixing the error @AlejandroFernandezLuces! |
Description
This PR improves the usability of some methods in the plotting class. This class was meant to be used inside eplot, vplot.. functions, but since some use cases involve using it standalone, I improved it's usability and documentation.
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)