-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable mako ⚡ #11326
feat: enable mako ⚡ #11326
Conversation
Walkthrough这些更改涉及在 Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎊 PR Preview has been successfully built and deployed to https://ant-design-pro-preview-pr-11326.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- config/config.ts (2 hunks)
- config/proxy.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- config/proxy.ts
Additional comments not posted (1)
config/config.ts (1)
150-155
: Verify the completeness of themako
configuration.The addition of the
mako
configuration aligns with the PR objectives to enable rapid development using the Mako framework. However, the configuration block is empty. Please verify if this is intentional or if additional parameters are required for optimal integration.The code changes are approved.
Consider verifying the completeness of the
mako
configuration by consulting the Mako documentation or relevant project requirements.
/** | ||
* @name 是否开启 mako | ||
* @description 使用 mako 极速研发 | ||
* @doc https://umijs.org/docs/api/config#mako | ||
*/ | ||
mako: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assess the impact of removing mfsu
.
The removal of the mfsu
configuration option marks a significant change in the project's build strategy. It is crucial to assess the impact of this change on the build performance and ensure that all dependencies and project requirements are still being met.
Consider conducting a thorough impact analysis to verify that the removal of mfsu
does not adversely affect the project's build process or performance.
windows 还不支持。@sorrycc @stormslowly |
https://umijs.org/docs/api/config#mako
https://makojs.dev/
Summary by CodeRabbit
新功能
错误修复
mfsu
配置,以简化构建过程。杂项