feat: optimized connect-button code #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 557e735 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
==========================================
+ Coverage 99.54% 99.61% +0.06%
==========================================
Files 92 92
Lines 4214 4197 -17
Branches 433 423 -10
==========================================
- Hits 4195 4181 -14
+ Misses 18 15 -3
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
有两行改动测试没有覆盖到，需要加一下测试样例。 |
thinkasany
reviewed
Jan 11, 2024
| @@ -94,7 +94,12 @@ describe('more-wallets-connect', () => { | |||
| }); | |||
| fireEvent.click(walletItems[1]!); | |||
| await vi.waitFor(() => { | |||
| expect(baseElement.querySelector('.ant-web3-connect-modal-qr-code-box')).toBeTruthy(); | |||
| const qrCodeBox = baseElement.querySelector('.ant-web3-connect-modal-qr-code-box'); | |||
| if (qrCodeBox !== null) { | |||
There was a problem hiding this comment.
这边原来的写法没问题吧？ 为什么要改成这样。 !== null 才except toBeTruthy 不是多余了。 然后现在落后主分支很多代码了，可以同步一下主分支的代码。
thinkasany
reviewed
Jan 11, 2024
thinkasany
approved these changes
Jan 11, 2024
|
覆盖率要提升下，有两行代码 miss 了。 |
yutingzhao1991
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.