Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add s3PathStyleAccessEnabled setting #6671

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add s3PathStyleAccessEnabled setting #6671

wants to merge 2 commits into from
+45 −5

Conversation

burak-58
Copy link
Contributor

PathStyleAccessEnabled configuration parameter is added to application settings.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
77.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

mekya
mekya requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement.
One thing need to removed and make the test coverage pass the %80

src/main/java/io/antmedia/AppSettings.java
/**
* @hidden
*/
private static final String SETTINGS_S3_PATH_STYLE_ACCESS_ENABLED = "settings.pathStyleAccessEnabled";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use this convention anymore. We directly use field name. Please remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mekya mekya mekya requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burak-58 @mekya