Fix WebReflection#358 - Cleanup accessors before dropping the attribute

anthony-redFox · May 10, 2019 · 6262e1d · 6262e1d
1 parent 9f98c42
commit 6262e1d
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 23 deletions.
diff --git a/cjs/objects/Updates.js b/cjs/objects/Updates.js
@@ -130,12 +130,13 @@ Tagger.prototype = {
       return newValue => {
         if (oldValue !== newValue) {
           oldValue = newValue;
-          if (node[name] !== newValue) {
-            node[name] = newValue;
-            if (newValue == null) {
-              node.removeAttribute(name);
-            }
+          if (node[name] !== newValue && newValue == null) {
+            // cleanup on null to avoid silly IE/Edge bug
+            node[name] = '';
+            node.removeAttribute(name);
           }
+          else
+            node[name] = newValue;
         }
       };
     }

diff --git a/esm.js b/esm.js
diff --git a/esm/objects/Updates.js b/esm/objects/Updates.js
@@ -130,12 +130,13 @@ Tagger.prototype = {
       return newValue => {
         if (oldValue !== newValue) {
           oldValue = newValue;
-          if (node[name] !== newValue) {
-            node[name] = newValue;
-            if (newValue == null) {
-              node.removeAttribute(name);
-            }
+          if (node[name] !== newValue && newValue == null) {
+            // cleanup on null to avoid silly IE/Edge bug
+            node[name] = '';
+            node.removeAttribute(name);
           }
+          else
+            node[name] = newValue;
         }
       };
     }

diff --git a/index.js b/index.js
@@ -1549,13 +1549,11 @@ var hyperHTML = (function (document) {
               if (oldValue !== newValue) {
                 oldValue = newValue;
 
-                if (node[name] !== newValue) {
-                  node[name] = newValue;
-
-                  if (newValue == null) {
-                    node.removeAttribute(name);
-                  }
-                }
+                if (node[name] !== newValue && newValue == null) {
+                  // cleanup on null to avoid silly IE/Edge bug
+                  node[name] = '';
+                  node.removeAttribute(name);
+                } else node[name] = newValue;
               }
             };
           } else if (name in Intent.attributes) {

diff --git a/min.js b/min.js
diff --git a/test/edge.html b/test/edge.html
@@ -4,10 +4,10 @@
     <title>Edge test</title>
     <script>document.write('<script src="../index.js?_=' + Math.random() + '"><' + '/script>')</script>
     <script>
-this.onload = () => {
-  hyperHTML.adopt(document.body)`<div><ul></ul>${'OK'}<hr></div>`;
+this.onload = function () {
+  hyperHTML.bind(document.body)(['<textarea rows="3" value="', '"/>'], null);
 };
     </script>
   </head>
-  <body><div><ul></ul>NO<hr></div></body>
+  <body></body>
 </html>
diff --git a/umd.js b/umd.js