Add shouldShowRequestPermissionRationale method #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tony---Zhang
force-pushed
the
add_should_show_request_method
branch
from
8137230 to
707fd3a
Compare
| */ | ||
| @SuppressWarnings("unused") | ||
| public static boolean shouldShowRequestPermissionRationale(@Nullable Activity activity, @NonNull String permission) { | ||
| return activity == null || ActivityCompat.shouldShowRequestPermissionRationale(activity, permission); |
There was a problem hiding this comment.
I think this should be activity != null && ActivityCompat... because if the activity is null (let's assume we are in a Fragment detached from its parent activity), then actually requesting the permission will fail as it also requires an activity, which means we don't care about showing the rationale because we won't be able to show the permissions request dialog.
tonirmv
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PermissonManager miss an important method, so I just added it.
Add shouldShowRequestPermissionRationale method into the PermissionManager.