This repository has been archived by the owner on May 19, 2020. It is now read-only.
implementing trial for text translation on templates #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ydrasil
reviewed
Jun 6, 2017
| def get_translations_file(): | ||
| supported_languages = app.config.get('TRANSLATION_FILES').keys() | ||
| lang = (request.accept_languages.best_match(supported_languages) or | ||
| supported_languages[0]) |
There was a problem hiding this comment.
Are we sure that we'll always have at least 1 language in app.config.get('TRANSLATION_FILES').keys() ?
There was a problem hiding this comment.
Good point. We should in most cases, but indeed the system should still work if the translation were not found.
Ydrasil
reviewed
Jun 6, 2017
core/templates.py
Outdated
| from tcii18n.template import flask_methods | ||
|
|
||
| import gfm |
There was a problem hiding this comment.
I'm not sure but gfm import have to be with flask and tcii18n import or not ?
There was a problem hiding this comment.
that's correct, it should be above.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a sample translation for the title.
Note that you need to setup a csv file and adapt your settings.py