refactor: add ToolRegistry #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
rmarescu
force-pushed
the
rmarescu/tool-registry
branch
from
eae6747 to
32480a7
Compare
rmarescu
commented
Mar 2, 2025
| import { LanguageModelV1FinishReason } from "@ai-sdk/provider"; | ||
| import { | ||
| CoreMessage, | ||
| CoreTool, |
There was a problem hiding this comment.
Deprecated in Vercel AI SDK.
| AnthropicModelFamily, | ||
| Record<AnthropicToolType, AnthropicToolVersion> | ||
| > = { | ||
| "claude-3-5": { |
There was a problem hiding this comment.
Easy to extend with 3.7.
| tools["bash"] = bashToolEntry.factory(); | ||
| } catch (error) { | ||
| if (!(error instanceof ShortestError)) throw error; | ||
| this.log.trace("Bash tool not found for model, skipping", { model }); |
There was a problem hiding this comment.
If a tool is not found (e.g. bash for 3.7 not yet available upstream), the package will still work without the tool.
| }); | ||
| }); | ||
|
|
||
| it("registers tools with expected keys", () => { |
There was a problem hiding this comment.
This ensures all the tools available are properly registered. If a tool doesn't get registered, and not passed to the AI, the AI will do its best to complete the task with the missing tool. It will not be obvious - through a script error - that a tool is missing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implement a comprehensive refactoring of the AI tools system
Why
In preparation for adding Claude 3.7.
Ref #369 (comment)