The ANTLRv4 grammar is now equivalent to the ANTLRv3 grammar #4424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The LexBasic.g4 grammar has been removed and the few used rules have been taken over into ANTLRv4Lexer.g4. This lowers complexity and increases readability of error messages (e.g. missing ';' instead of missing SEMI). - The wrong definition of element options for action (and sempred) blocks has been fixed. - A predefined token file is now part of the set to make sure tokens appear in the right order (for tree walkers that were ported from ANTLRv3). This grammar is now used in antlr-ng for generating parser, so it should also appear as the official grammar (since the one in ANTLRv4 is actually a v3 grammar).
mike-lischke
changed the title
|
We're going to need the predefined.tokens file in grammars-v4/antlr/antlr4/predefined.tokens since it's source code for the grammar and antlr4 fails without the file. Github Actions says success, but the build failed. It will be fixed with the antlr-ng PR #4385. Thanks. |
|
Oh, I didn't know tokens files are ignored. Should I force-add it or do you have a different solution? |
|
The .tokens file isn't ignored apparently. The old "antlr4" tool requires the file, fails with |
|
@mike-lischke thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This grammar is now used in antlr-ng for generating parsers, so it should also appear as the official grammar (since the one in ANTLRv4 is actually a v3 grammar).