Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jump on first press #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidbiller
Copy link

No description provided.

@antonKalinin
Copy link
Owner

Hey @davidbiller, many thanks for PR. I've checked new behaviour with changes you made. I looks like it fixes scrolling issue, but from other hand breaks vertical moving of picture. I now looking for solution to fix both problems (maybe some big changes needed).

@davidbiller
Copy link
Author

So can you explain what do you mean? i can move the image in both directions...

@antonKalinin
Copy link
Owner

antonKalinin commented Dec 9, 2018

I cant move image up or down. If I swipe fast image view will close, but if vertical velocity is low, then image doesn't moving.

@danielgindi
Copy link

danielgindi commented Aug 19, 2019

The real solution is to add this as the bottom of the constructor:

        this.state.imageTranslate = { x, y };
        this.state.imageScale = this.getInitialScale();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants