Skip to content

Commit

Permalink
Merge pull request bigbluebutton#22155 from antonbsa/flaky-tests-3.1
Browse files Browse the repository at this point in the history
test: Flag all failing test with new UI as flaky
  • Loading branch information
antonbsa authored Jan 31, 2025
2 parents 2a167e2 + d5df9c7 commit d4e73ea
Show file tree
Hide file tree
Showing 12 changed files with 49 additions and 49 deletions.
2 changes: 1 addition & 1 deletion bigbluebutton-tests/playwright/breakout/breakout.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const { test } = require('../fixtures');
const { Create } = require('./create');
const { Join } = require('./join');

test.describe.parallel('Breakout', { tag: '@ci' }, () => {
test.describe.parallel('Breakout', { tag: ['@ci', '@flaky-3.1'] }, () => {
test.describe.parallel('Creating', () => {
test('Create Breakout room', async ({ browser, context, page }) => {
const create = new Create(browser, context);
Expand Down
8 changes: 4 additions & 4 deletions bigbluebutton-tests/playwright/chat/chat.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ test.describe('Chat', { tag: '@ci' }, () => {
});

// https://docs.bigbluebutton.org/3.0/testing/release-testing/#private-message-automated
test('Send private message', async () => {
test('Send private message', { tag: '@flaky-3.1' }, async () => {
await chat.sendPrivateMessage();
});

Expand All @@ -43,7 +43,7 @@ test.describe('Chat', { tag: '@ci' }, () => {
await chat.emptyMessage();
});

test('Copy and paste public message', async () => {
test('Copy and paste public message', { tag: '@flaky-3.1' }, async () => {
await chat.copyPastePublicMessage();
})

Expand All @@ -55,7 +55,7 @@ test.describe('Chat', { tag: '@ci' }, () => {
await chat.emojiCopyChat();
});

test('Close private chat', async () => {
test('Close private chat', { tag: '@flaky-3.1' }, async () => {
await chat.closePrivateChat();
});

Expand Down Expand Up @@ -85,7 +85,7 @@ test.describe('Chat', { tag: '@ci' }, () => {

// failure only reproducible in CI (user leaves but keeps shown in the mod user list)
//! flaky flag recently removed in order to see current behavior
test('Private chat disabled when user leaves meeting', { tag: '@ci' }, async () => {
test('Private chat disabled when user leaves meeting', { tag: ['@ci', '@flaky-3.1'] }, async () => {
await chat.chatDisabledUserLeaves();
});
});
2 changes: 1 addition & 1 deletion bigbluebutton-tests/playwright/layouts/layouts.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const { fullyParallel } = require('../playwright.config');
const { Layouts } = require('./layouts');
const { initializePages } = require('../core/helpers');

test.describe('Layout', { tag: '@ci' }, () => {
test.describe('Layout', { tag: ['@ci', '@flaky-3.1'] }, () => {
const layouts = new Layouts();

test.describe.configure({ mode: fullyParallel ? 'parallel' : 'serial' });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const { LearningDashboard } = require('./learningdashboard');
const c = require('../parameters/constants');
const { initializePages } = require('../core/helpers');

test.describe('Learning Dashboard', { tag: '@ci' } , async () => {
test.describe('Learning Dashboard', { tag: ['@ci', '@flaky-3.1'] } , async () => {
const learningDashboard = new LearningDashboard();

test.describe.configure({ mode: fullyParallel ? 'parallel' : 'serial' });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const { recordMeeting } = require('../parameters/constants');
const { linkIssue } = require('../core/helpers');

test.describe.parallel('Notifications', { tag: '@ci' }, () => {
test('Save settings notification', async ({ browser, context, page }) => {
test('Save settings notification', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const notifications = new Notifications(browser, context);
await notifications.initModPage(page);
await notifications.saveSettingsNotification();
Expand All @@ -19,7 +19,7 @@ test.describe.parallel('Notifications', { tag: '@ci' }, () => {
await notifications.audioNotification();
});

test('User join notification', async ({ browser, context, page }) => {
test('User join notification', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const notifications = new Notifications(browser, context);
await notifications.initModPage(page);
await notifications.getUserJoinPopupResponse();
Expand All @@ -32,7 +32,7 @@ test.describe.parallel('Notifications', { tag: '@ci' }, () => {
await notifications.raiseAndLowerHandNotification();
});

test.describe.parallel('Chat', () => {
test.describe.parallel('Chat', { tag: '@flaky-3.1' }, () => {
test('Public Chat notification', async ({ browser, context, page }) => {
const chatNotifications = new ChatNotifications(browser, context);
await chatNotifications.initPages(page);
Expand All @@ -51,7 +51,7 @@ test.describe.parallel('Notifications', { tag: '@ci' }, () => {
});

test.describe.parallel('Recording', () => {
test('Notification appearing when user is not in audio', async ({ browser, page }) => {
test('Notification appearing when user is not in audio', { tag: '@flaky-3.1' }, async ({ browser, page }) => {
const recordingNotifications = new RecordingNotifications(browser, page);
await recordingNotifications.init(true, true, { createParameter: recordMeeting });
await recordingNotifications.notificationNoAudio();
Expand All @@ -63,21 +63,21 @@ test.describe.parallel('Notifications', { tag: '@ci' }, () => {
await recordingNotifications.notificationListenOnly();
});

test('No notification appearing when user is in audio', async ({ browser, page }) => {
test('No notification appearing when user is in audio', { tag: '@flaky-3.1' }, async ({ browser, page }) => {
const recordingNotifications = new RecordingNotifications(browser, page);
await recordingNotifications.init(true, true, { createParameter: recordMeeting });
await recordingNotifications.noNotificationInAudio();
});

test('Modal appearing when user wants to start recording', async ({ browser, page }) => {
test('Modal appearing when user wants to start recording', { tag: '@flaky-3.1' }, async ({ browser, page }) => {
const recordingNotifications = new RecordingNotifications(browser, page);
await recordingNotifications.init(true, true, { createParameter: recordMeeting });
await recordingNotifications.modalStartRecording();
});
});

test.describe.parallel('Presenter', () => {
test('Poll results notification', async ({ browser, context, page }) => {
test('Poll results notification', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const presenterNotifications = new PresenterNotifications(browser, context);
await presenterNotifications.initPages(page);
await presenterNotifications.modPage.closeAllToastNotifications();
Expand Down
2 changes: 1 addition & 1 deletion bigbluebutton-tests/playwright/options/options.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const { fullyParallel } = require('../playwright.config');
const { Options } = require('./options');
const { initializePages } = require('../core/helpers');

test.describe('Options', { tag: '@ci' }, () => {
test.describe('Options', { tag: ['@ci', '@flaky-3.1'] }, () => {
const options = new Options();

test.describe.configure({ mode: fullyParallel ? 'parallel' : 'serial' });
Expand Down
44 changes: 22 additions & 22 deletions bigbluebutton-tests/playwright/parameters/parameters.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ test.describe.parallel('Create Parameters', { tag: '@ci' }, () => {
});

test.describe.parallel('Banner', () => {
test('Banner Text', async ({ browser, context, page }) => {
test('Banner Text', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const createParam = new CreateParameters(browser, context);
await createParam.initModPage(page, true, { createParameter: c.bannerText });
await createParam.bannerText();
Expand Down Expand Up @@ -60,7 +60,7 @@ test.describe.parallel('Create Parameters', { tag: '@ci' }, () => {
await createParam.muteOnStart();
});

test('Allow Mods To Unmute Users', async ({ browser, context, page }) => {
test('Allow Mods To Unmute Users', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const createParam = new CreateParameters(browser, context);
await createParam.initModPage(page, true, { createParameter: c.allowModsToUnmuteUsers });
await createParam.allowModsToUnmuteUsers(context);
Expand All @@ -87,23 +87,23 @@ test.describe.parallel('Create Parameters', { tag: '@ci' }, () => {
await createParam.lockSettingsDisablePublicChat();
});

test('Lock Settings Hide User List', async ({ browser, context, page }) => {
test('Lock Settings Hide User List', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const createParam = new CreateParameters(browser, context);
await createParam.initModPage(page, true, { createParameter: c.lockSettingsHideUserList });
await createParam.initUserPage(true, context);
await createParam.initUserPage2(true, context);
await createParam.lockSettingsHideUserList();
});

test('Allow Moderator To Eject Cameras', async ({ browser, context, page }) => {
test('Allow Moderator To Eject Cameras', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const createParam = new CreateParameters(browser, context);
await createParam.initModPage(page, true, { createParameter: c.allowModsToEjectCameras });
await createParam.initUserPage(true, context);
await createParam.allowModsToEjectCameras();
});

test.describe.parallel('Disabled Features', () => {
test.describe.serial(() => {
test.describe.serial('', { tag: '@flaky-3.1' }, () => {
test('Breakout rooms', async ({ browser, context, page }) => {
const disabledFeatures = new DisabledFeatures(browser, context);
await disabledFeatures.initModPage(page, true, { createParameter: c.breakoutRoomsDisabled });
Expand Down Expand Up @@ -145,7 +145,7 @@ test.describe.parallel('Create Parameters', { tag: '@ci' }, () => {
});
});

test.describe.serial(() => {
test.describe.serial('', { tag: '@flaky-3.1' }, () => {
test('Chat', async ({ browser, context, page }) => {
const disabledFeatures = new DisabledFeatures(browser, context);
await disabledFeatures.initModPage(page, true, { createParameter: c.chatDisabled });
Expand All @@ -158,7 +158,7 @@ test.describe.parallel('Create Parameters', { tag: '@ci' }, () => {
});
});

test.describe.serial(() => {
test.describe.serial('', { tag: '@flaky-3.1' }, () => {
test('External Videos', async ({ browser, context, page }) => {
const disabledFeatures = new DisabledFeatures(browser, context);
await disabledFeatures.initModPage(page, true, { createParameter: c.externalVideosDisabled });
Expand All @@ -184,7 +184,7 @@ test.describe.parallel('Create Parameters', { tag: '@ci' }, () => {
});
});

test.describe.serial(() => {
test.describe.serial('', { tag: '@flaky-3.1' }, () => {
test('Learning Dashboard', async ({ browser, context, page }) => {
const disabledFeatures = new DisabledFeatures(browser, context);
await disabledFeatures.initModPage(page, true, { createParameter: c.learningDashboardDisabled });
Expand All @@ -197,7 +197,7 @@ test.describe.parallel('Create Parameters', { tag: '@ci' }, () => {
});
});

test.describe.serial(() => {
test.describe.serial('', { tag: '@flaky-3.1' }, () => {
test('Polls', async ({ browser, context, page }) => {
const disabledFeatures = new DisabledFeatures(browser, context);
await disabledFeatures.initModPage(page, true, { createParameter: c.pollsDisabled });
Expand All @@ -223,7 +223,7 @@ test.describe.parallel('Create Parameters', { tag: '@ci' }, () => {
});
});

test.describe.serial(() => {
test.describe.serial('', { tag: '@flaky-3.1' }, () => {
test('Shared Notes', async ({ browser, context, page }) => {
const disabledFeatures = new DisabledFeatures(browser, context);
await disabledFeatures.initModPage(page, true, { createParameter: c.sharedNotesDisabled });
Expand All @@ -249,7 +249,7 @@ test.describe.parallel('Create Parameters', { tag: '@ci' }, () => {
});
});

test.describe.serial(() => {
test.describe.serial('', { tag: '@flaky-3.1' }, () => {
test('Download Presentation With Annotations', async ({ browser, context, page }) => {
const disabledFeatures = new DisabledFeatures(browser, context);
await disabledFeatures.initModPage(page, true, { createParameter: c.downloadPresentationWithAnnotationsDisabled });
Expand All @@ -262,7 +262,7 @@ test.describe.parallel('Create Parameters', { tag: '@ci' }, () => {
});
});

test.describe.serial(() => {
test.describe.serial('', { tag: '@flaky-3.1' }, () => {
test('Import Presentation With Annotations From Breakout Rooms', async ({ browser, context, page }) => {
const disabledFeatures = new DisabledFeatures(browser, context);
await disabledFeatures.initModPage(page, true, { createParameter: c.importPresentationWithAnnotationsFromBreakoutRoomsDisabled });
Expand All @@ -275,7 +275,7 @@ test.describe.parallel('Create Parameters', { tag: '@ci' }, () => {
});
});

test.describe.serial(() => {
test.describe.serial('', { tag: '@flaky-3.1' }, () => {
test('Import Shared Notes From Breakout Rooms', async ({ browser, context, page }) => {
const disabledFeatures = new DisabledFeatures(browser, context);
await disabledFeatures.initModPage(page, true, { createParameter: c.importSharedNotesFromBreakoutRoomsDisabled });
Expand Down Expand Up @@ -327,7 +327,7 @@ test.describe.parallel('Create Parameters', { tag: '@ci' }, () => {
});
});

test.describe.serial(() => {
test.describe.serial('', { tag: '@flaky-3.1' }, () => {
test('Camera As Content', async ({ browser, context, page }) => {
const disabledFeatures = new DisabledFeatures(browser, context);
await disabledFeatures.initModPage(page, true, { createParameter: c.cameraAsContent });
Expand All @@ -343,7 +343,7 @@ test.describe.parallel('Create Parameters', { tag: '@ci' }, () => {
});

test.describe.parallel('Custom Parameters', { tag: '@ci' }, () => {
test('Show Public Chat On Login', async ({ browser, context, page }) => {
test('Show Public Chat On Login', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const customParam = new CustomParameters(browser, context);
await customParam.initModPage(page, true, { joinParameter: c.showPublicChatOnLogin });
await customParam.showPublicChatOnLogin();
Expand All @@ -361,33 +361,33 @@ test.describe.parallel('Custom Parameters', { tag: '@ci' }, () => {
await customParam.clientTitle();
});

test('Display Branding Area', async ({ browser, context, page }) => {
test('Display Branding Area', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const customParam = new CustomParameters(browser, context);
await customParam.initModPage(page, true, { createParameter: `${c.displayBrandingArea}&${encodeCustomParams(c.logo)}` });
await customParam.displayBrandingArea();
});

test('Shortcuts', async ({ browser, context, page }) => {
test('Shortcuts', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const customParam = new CustomParameters(browser, context);
const shortcutParam = getAllShortcutParams();
await customParam.initModPage(page, true, { joinParameter: encodeCustomParams(shortcutParam) });
await customParam.initUserPage(true, context, { useModMeetingId: true });
await customParam.shortcuts();
});

test('Custom Styles: CSS code', async ({ browser, context, page }) => {
test('Custom Styles: CSS code', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const customParam = new CustomParameters(browser, context);
await customParam.initModPage(page, true, { joinParameter: encodeCustomParams(c.customStyle) });
await customParam.customStyle();
});

test('Custom Styles: URL', async ({ browser, context, page }) => {
test('Custom Styles: URL', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const customParam = new CustomParameters(browser, context);
await customParam.initModPage(page, true, { joinParameter: encodeCustomParams(c.customStyleUrl) });
await customParam.customStyle();
});

test('Auto Swap Layout', async ({ browser, context, page }) => {
test('Auto Swap Layout', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const customParam = new CustomParameters(browser, context);
await customParam.initModPage(page, true, { joinParameter: c.autoSwapLayout });
await customParam.autoSwapLayout();
Expand All @@ -399,7 +399,7 @@ test.describe.parallel('Custom Parameters', { tag: '@ci' }, () => {
await customParam.hideActionsBarTest();
});

test('Override Default Locale', async ({ browser, context, page }) => {
test('Override Default Locale', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const customParam = new CustomParameters(browser, context);
await customParam.initModPage(page, true, { joinParameter: c.overrideDefaultLocale });
await customParam.overrideDefaultLocaleTest();
Expand Down Expand Up @@ -456,7 +456,7 @@ test.describe.parallel('Custom Parameters', { tag: '@ci' }, () => {
});

test.describe.parallel('Presentation', () => {
test('Hide Presentation on join', async ({ browser, context, page }) => {
test('Hide Presentation on join', { tag: '@flaky-3.1' }, async ({ browser, context, page }) => {
const customParam = new CustomParameters(browser, context);
await customParam.initModPage(page, true, { joinParameter: c.hidePresentationOnJoin });
await customParam.initUserPage(true, context, { useModMeetingId: true, joinParameter: c.hidePresentationOnJoin });
Expand Down
2 changes: 1 addition & 1 deletion bigbluebutton-tests/playwright/polling/polling.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const { PARAMETER_HIDE_PRESENTATION_TOAST } = require('../core/constants');

const hidePresentationToast = encodeCustomParams(PARAMETER_HIDE_PRESENTATION_TOAST);

test.describe('Polling', { tag: '@ci' }, async () => {
test.describe('Polling', { tag: ['@ci', '@flaky-3.1'] }, async () => {
const polling = new Polling();

test.describe.configure({ mode: fullyParallel ? 'parallel' : 'serial' });
Expand Down
Loading

0 comments on commit d4e73ea

Please sign in to comment.