Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 3.12 maybe #70

Merged
merged 7 commits into from
Jan 7, 2025
Merged

support 3.12 maybe #70

merged 7 commits into from
Jan 7, 2025

Conversation

newhouse
Copy link
Contributor

No description provided.

@newhouse newhouse changed the base branch from 5-point-0 to master December 27, 2024 20:54
@newhouse
Copy link
Contributor Author

@rgimenez maybe you can re-try your branch against this one, please?

I couldn't get support for 3.12 to work with much ease so I'm hoping for some community help.

@rgimen3z
Copy link

rgimen3z commented Dec 30, 2024

@rgimenez maybe you can re-try your branch against this one, please?

I couldn't get support for 3.12 to work with much ease so I'm hoping for some community help.

thanks @newhouse, I am able to install in our service running 3.12 with these changes. Looks like you're just having some issues with isort fighting black. I think you may be able to fix the issue if you copy over the tweak I made to .isort.cfg in https://github.com/anvilco/python-anvil/pull/65/files

@rgimen3z
Copy link

rgimen3z commented Jan 3, 2025

@rgimenez maybe you can re-try your branch against this one, please?
I couldn't get support for 3.12 to work with much ease so I'm hoping for some community help.

thanks @newhouse, I am able to install in our service running 3.12 with these changes. Looks like you're just having some issues with isort fighting black. I think you may be able to fix the issue if you copy over the tweak I made to .isort.cfg in https://github.com/anvilco/python-anvil/pull/65/files

opened a PR against your branch @newhouse , let's see if this does the trick: #71

@newhouse
Copy link
Contributor Author

newhouse commented Jan 6, 2025

@rgimen3z I think maybe I got it and have published as 5.0.1b1...can you try it out?

Copy link

@rgimen3z rgimen3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to install on a service running python 3.12 now, thanks! 🫶

@newhouse newhouse requested a review from fostimus January 7, 2025 00:20
@newhouse newhouse merged commit de70587 into master Jan 7, 2025
5 checks passed
@newhouse newhouse deleted the 5-point-0-py3-12 branch January 7, 2025 01:39
@newhouse
Copy link
Contributor Author

newhouse commented Jan 7, 2025

Published as 5.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants