Broadcast to others #191
Merged
Broadcast to others #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palkan
force-pushed
the
feat/broadcast-to-others
branch
from
cfbeb7e to
9220ad4
Compare
palkan
force-pushed
the
feat/broadcast-to-others
branch
from
9220ad4 to
c634349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This feature brings the ability to deliver broadcast events to everyone except the current session.
Based on anycable/anycable#218 and anycable/anycable-go#194
What changes did you make? (overview)
Server#broadcastandChannel.broadcast_tomethods to accept broadcast options as their third argumentAnyCable::Rails.broadcasting_to_other { }method to set the option for the inner code block (in case broadcast is called indirectly, e.g., with Turbo Streams)current_socket_idto jobsIs there anything you'd like reviewers to focus on?
Checklist