Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/JS-5569: Email collection tooltip #1050

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

mhlv
Copy link
Contributor

@mhlv mhlv commented Nov 13, 2024


  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@mhlv mhlv self-assigned this Nov 13, 2024
@mhlv mhlv marked this pull request as ready for review November 13, 2024 19:23
src/ts/component/form/pin.tsx Outdated Show resolved Hide resolved
src/ts/component/menu/onboarding.tsx Outdated Show resolved Hide resolved
src/ts/component/util/emailCollectionForm.tsx Outdated Show resolved Hide resolved
src/ts/docs/help/onboarding.ts Outdated Show resolved Hide resolved
@ra3orblade ra3orblade merged commit 4085251 into main Nov 14, 2024
3 checks passed
@ra3orblade ra3orblade deleted the feature/JS-5569-email-collection-tooltip branch November 14, 2024 13:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants