Feature/JS-5093: Publishing #988
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json was generated by castom code from mapping, I don't know how to do the same in easy way in middleware yet. So for now I'm just sending the whole object instead of id.
haron-IV
approved these changes
Nov 5, 2024
Comment on lines
+4
to
+9
| Row = 0, | ||
| Column = 1, | ||
| Div = 2, | ||
| Header = 3, | ||
| TableRows = 4, | ||
| TableColumns = 5, |
src/ts/lib/action.ts
Outdated
Comment on lines
815
to
817
| if (message.error.code) { | ||
| return; | ||
| }; |
There was a problem hiding this comment.
you can just skip brackets and make in online.
if (message.error.code) return
There was a problem hiding this comment.
We do not write one-line if clauses.
Comment on lines
+195
to
+201
| export const ObjectPublish = (response: Rpc.Object.Publish.Response) => { | ||
| return { | ||
| cid: response.getPublishcid(), | ||
| key: response.getPublishfilekey(), | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
export const ObjectPublish = (response: Rpc.Object.Publish.Response) => ({
cid: response.getPublishcid(),
key: response.getPublishfilekey(),
})I find it nicer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?