Skip to content

Commit

Permalink
metrics: remove optimistic_slot_elapsed (#2717)
Browse files Browse the repository at this point in the history
* metrics: remove optimistic_slot_elapsed

* remove optimistic_slot_elapsed from grafana dashboard json
  • Loading branch information
yihau authored Sep 4, 2024
1 parent b5432b0 commit 05361a9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 145 deletions.
9 changes: 0 additions & 9 deletions core/src/optimistic_confirmation_verifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,6 @@ impl OptimisticConfirmationVerifier {
return;
}

datapoint_info!(
"optimistic_slot_elapsed",
(
"average_elapsed_ms",
self.last_optimistic_slot_ts.elapsed().as_millis() as i64,
i64
),
);

// We don't have any information about ancestors before the snapshot root,
// so ignore those slots
for (new_optimistic_slot, hash) in new_optimistic_slots {
Expand Down
136 changes: 0 additions & 136 deletions metrics/scripts/grafana-provisioning/dashboards/cluster-monitor.json
Original file line number Diff line number Diff line change
Expand Up @@ -10628,142 +10628,6 @@
"alignLevel": null
}
},
{
"aliasColors": {
"cluster-info.repair": "#ba43a9",
"replay_stage-new_leader.last": "#00ffbb",
"tower-vote.last": "#00ffbb",
"window-service.receive": "#b7dbab",
"window-stage.consumed": "#5195ce"
},
"bars": false,
"dashLength": 10,
"dashes": false,
"datasource": "$datasource",
"fieldConfig": {
"defaults": {
"custom": {}
},
"overrides": []
},
"fill": 1,
"fillGradient": 0,
"gridPos": {
"h": 5,
"w": 8,
"x": 16,
"y": 83
},
"hiddenSeries": false,
"id": 59,
"legend": {
"alignAsTable": false,
"avg": false,
"current": false,
"max": false,
"min": false,
"show": true,
"total": false,
"values": false
},
"lines": false,
"linewidth": 1,
"links": [],
"nullPointMode": "null",
"options": {
"alertThreshold": true
},
"percentage": false,
"pluginVersion": "7.4.3",
"pointradius": 2,
"points": true,
"renderer": "flot",
"seriesOverrides": [],
"spaceLength": 10,
"stack": false,
"steppedLine": false,
"targets": [
{
"groupBy": [
{
"params": [
"$__interval"
],
"type": "time"
},
{
"params": [
"null"
],
"type": "fill"
}
],
"hide": false,
"measurement": "cluster_info-vote-count",
"orderByTime": "ASC",
"policy": "autogen",
"query": "SELECT last(\"average_elapsed_ms\") FROM \"$testnet\".\"autogen\".\"optimistic_slot_elapsed\" WHERE host_id::tag =~ /$hostid/ AND $timeFilter GROUP BY time($__interval)",
"rawQuery": true,
"refId": "A",
"resultFormat": "time_series",
"select": [
[
{
"params": [
"count"
],
"type": "field"
},
{
"params": [],
"type": "sum"
}
]
],
"tags": []
}
],
"thresholds": [],
"timeFrom": null,
"timeRegions": [],
"timeShift": null,
"title": "Average Time Between Optimistic Confirmations ($hostid)",
"tooltip": {
"shared": true,
"sort": 0,
"value_type": "individual"
},
"type": "graph",
"xaxis": {
"buckets": null,
"mode": "time",
"name": null,
"show": true,
"values": []
},
"yaxes": [
{
"format": "none",
"label": null,
"logBase": 1,
"max": null,
"min": null,
"show": true
},
{
"format": "short",
"label": null,
"logBase": 1,
"max": null,
"min": null,
"show": true
}
],
"yaxis": {
"align": false,
"alignLevel": null
}
},
{
"aliasColors": {
"cluster-info.repair": "#ba43a9",
Expand Down

0 comments on commit 05361a9

Please sign in to comment.