Skip to content

Commit

Permalink
Disallow --rocksdb-shred-compaction fifo in the validator
Browse files Browse the repository at this point in the history
The use of fifo compaction in rocksdb is deprecated (as of v2.0). The
current behavior emits a warning if fifo is set. This change removes
"fifo" as an option, leaving "level" as the only valid value for
--rocksdb-shred-compaction
  • Loading branch information
steviez committed Nov 3, 2024
1 parent 4994762 commit 230f779
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions validator/src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -666,14 +666,12 @@ pub fn app<'a>(version: &'a str, default_args: &'a DefaultArgs) -> App<'a, 'a> {
.long("rocksdb-shred-compaction")
.value_name("ROCKSDB_COMPACTION_STYLE")
.takes_value(true)
.possible_values(&["level", "fifo"])
.possible_values(&["level"])
.default_value(&default_args.rocksdb_shred_compaction)
.help(
"Controls how RocksDB compacts shreds. *WARNING*: You will lose your \
Blockstore data when you switch between options. Possible values are: \
'level': stores shreds using RocksDB's default (level) compaction. \
'fifo': stores shreds under RocksDB's FIFO compaction. This option is more \
efficient on disk-write-bytes of the Blockstore.",
'level': stores shreds using RocksDB's default (level) compaction.",
),
)
.arg(
Expand Down

0 comments on commit 230f779

Please sign in to comment.