v2.0: gossip: demote invalid duplicate proof errors to info (backport…

… of #2754) (#2759)

gossip: demote invalid duplicate proof errors to info (#2754)

* gossip: demote invalid duplicate proof errors to info

* pr feedback: explicitly list every enum

(cherry picked from commit 7b6e6c1)

Co-authored-by: Ashwin Sekar <[email protected]>

gossip/src/duplicate_shred.rs

@@ -93,6 +93,33 @@ pub enum Error {
     UnknownSlotLeader(Slot),
 }
 
+impl Error {
+    /// Errors indicating that the initial node submitted an invalid duplicate proof case
+    pub(crate) fn is_non_critical(&self) -> bool {
+        match self {
+            Self::SlotMismatch
+            | Self::InvalidShredVersion(_)
+            | Self::InvalidSignature
+            | Self::ShredTypeMismatch
+            | Self::InvalidDuplicateShreds
+            | Self::InvalidLastIndexConflict
+            | Self::InvalidErasureMetaConflict => true,
+            Self::BlockstoreInsertFailed(_)
+            | Self::DataChunkMismatch
+            | Self::DuplicateSlotSenderFailure
+            | Self::InvalidChunkIndex { .. }
+            | Self::InvalidDuplicateSlotProof
+            | Self::InvalidSizeLimit
+            | Self::InvalidShred(_)
+            | Self::NumChunksMismatch
+            | Self::MissingDataChunk
+            | Self::SerializationError(_)
+            | Self::TryFromIntError(_)
+            | Self::UnknownSlotLeader(_) => false,
+        }
+    }
+}
+
 /// Check that `shred1` and `shred2` indicate a valid duplicate proof
 ///     - Must be for the same slot
 ///     - Must match the expected shred version

gossip/src/duplicate_shred_handler.rs

@@ -57,8 +57,14 @@ impl DuplicateShredHandlerTrait for DuplicateShredHandler {
     fn handle(&mut self, shred_data: DuplicateShred) {
         self.cache_root_info();
         self.maybe_prune_buffer();
+        let slot = shred_data.slot;
+        let pubkey = shred_data.from;
         if let Err(error) = self.handle_shred_data(shred_data) {
-            error!("handle packet: {error:?}")
+            if error.is_non_critical() {
+                info!("Received invalid duplicate shred proof from {pubkey} for slot {slot}: {error:?}");
+            } else {
+                error!("Unable to process duplicate shred proof from {pubkey} for slot {slot}: {error:?}");
+            }
         }
     }
 }