pr feedback: comment, move existing check to blockstore fn

core/src/replay_stage.rs

@@ -1993,7 +1993,8 @@ impl ReplayStage {
     }
 
     /// Checks if it is time for us to start producing a leader block.
-    /// Additionally fails if:
+    /// Fails if:
+    /// - Current PoH has not satisfied criteria to start my leader block
     /// - Startup verification is not complete,
     /// - Bank forks already contains a bank for this leader slot
     /// - We have not landed a vote yet and the `wait_for_vote_to_start_leader` flag is set

ledger/src/blockstore.rs

@@ -4049,6 +4049,13 @@ impl Blockstore {
         Ok(duplicate_slots_iterator.map(|(slot, _)| slot))
     }
 
+    pub fn has_existing_shreds_for_slot(&self, slot: Slot) -> bool {
+        match self.meta(slot).unwrap() {
+            Some(meta) => meta.received > 0,
+            None => false,
+        }
+    }
+
     /// Returns the max root or 0 if it does not exist
     pub fn max_root(&self) -> Slot {
         self.max_root.load(Ordering::Relaxed)

poh/src/poh_recorder.rs

@@ -571,7 +571,7 @@ impl PohRecorder {
             return PohLeaderStatus::NotReached;
         };
 
-        if self.has_existing_shreds_for_slot(next_poh_slot) {
+        if self.blockstore.has_existing_shreds_for_slot(next_poh_slot) {
             // We already have existing shreds for this slot. This can happen when this block was previously
             // created and added to BankForks, however a recent PoH reset caused this bank to be removed
             // as it was not part of the rooted fork. If this slot is not the first slot for this leader,
@@ -594,13 +594,6 @@ impl PohRecorder {
         }
     }
 
-    fn has_existing_shreds_for_slot(&self, slot: Slot) -> bool {
-        match self.blockstore.meta(slot).unwrap() {
-            Some(meta) => meta.received > 0,
-            None => false,
-        }
-    }
-
     // returns (leader_first_tick_height_including_grace_ticks, leader_last_tick_height, grace_ticks) given the next
     //  slot this recorder will lead
     fn compute_leader_slot_tick_heights(