Skip to content

Commit

Permalink
remove solana-sdk from solana-pubsub-client (#3718)
Browse files Browse the repository at this point in the history
* remove solana-sdk dep from pubsub-client

* replace account_decoder with account_decoder_client_types

* fix dev deps
  • Loading branch information
kevinheavey authored Nov 20, 2024
1 parent 8030d2d commit cf3fe5c
Show file tree
Hide file tree
Showing 6 changed files with 30 additions and 15 deletions.
7 changes: 5 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions programs/sbf/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions pubsub-client/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@ semver = { workspace = true }
serde = { workspace = true }
serde_derive = { workspace = true }
serde_json = { workspace = true }
solana-account-decoder = { workspace = true }
solana-account-decoder-client-types = { workspace = true }
solana-clock = { workspace = true }
solana-pubkey = { workspace = true }
solana-rpc-client-api = { workspace = true }
solana-sdk = { workspace = true }
solana-signature = { workspace = true }
thiserror = { workspace = true }
tokio = { workspace = true, features = ["full"] }
tokio-stream = { workspace = true }
Expand All @@ -30,6 +32,8 @@ url = { workspace = true }

[dev-dependencies]
anyhow = { workspace = true }
solana-commitment-config = { workspace = true }
solana-pubkey = { workspace = true, features = ["rand"] }

[package.metadata.docs.rs]
targets = ["x86_64-unknown-linux-gnu"]
6 changes: 4 additions & 2 deletions pubsub-client/src/nonblocking/pubsub_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,9 @@ use {
log::*,
serde::de::DeserializeOwned,
serde_json::{json, Map, Value},
solana_account_decoder::UiAccount,
solana_account_decoder_client_types::UiAccount,
solana_clock::Slot,
solana_pubkey::Pubkey,
solana_rpc_client_api::{
config::{
RpcAccountInfoConfig, RpcBlockSubscribeConfig, RpcBlockSubscribeFilter,
Expand All @@ -188,7 +190,7 @@ use {
RpcSignatureResult, RpcVote, SlotInfo, SlotUpdate,
},
},
solana_sdk::{clock::Slot, pubkey::Pubkey, signature::Signature},
solana_signature::Signature,
std::collections::BTreeMap,
thiserror::Error,
tokio::{
Expand Down
12 changes: 7 additions & 5 deletions pubsub-client/src/pubsub_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@
//!
//! ```
//! use anyhow::Result;
//! use solana_sdk::commitment_config::CommitmentConfig;
//! use solana_commitment_config::CommitmentConfig;
//! use solana_pubkey::Pubkey;
//! use solana_pubsub_client::pubsub_client::PubsubClient;
//! use solana_rpc_client_api::config::RpcAccountInfoConfig;
//! use solana_sdk::pubkey::Pubkey;
//! use std::thread;
//!
//! fn get_account_updates(account_pubkey: Pubkey) -> Result<()> {
Expand Down Expand Up @@ -82,7 +82,7 @@
//! Ok(())
//! }
//! #
//! # get_account_updates(solana_sdk::pubkey::new_rand());
//! # get_account_updates(solana_pubkey::new_rand());
//! # Ok::<(), anyhow::Error>(())
//! ```
Expand All @@ -96,7 +96,9 @@ use {
value::Value::{Number, Object},
Map, Value,
},
solana_account_decoder::UiAccount,
solana_account_decoder_client_types::UiAccount,
solana_clock::Slot,
solana_pubkey::Pubkey,
solana_rpc_client_api::{
config::{
RpcAccountInfoConfig, RpcBlockSubscribeConfig, RpcBlockSubscribeFilter,
Expand All @@ -108,7 +110,7 @@ use {
RpcSignatureResult, RpcVote, SlotInfo, SlotUpdate,
},
},
solana_sdk::{clock::Slot, pubkey::Pubkey, signature::Signature},
solana_signature::Signature,
std::{
marker::PhantomData,
net::TcpStream,
Expand Down
6 changes: 4 additions & 2 deletions svm/examples/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit cf3fe5c

Please sign in to comment.