remove test for valid_client_facing_addr since it is no longer used

dos/src/main.rs

@@ -46,8 +46,7 @@ use {
     rand::{thread_rng, Rng},
     solana_bench_tps::{bench::generate_and_fund_keypairs, bench_tps_client::BenchTpsClient},
     solana_client::{
-        connection_cache::ConnectionCache,
-        tpu_client::TpuClientWrapper,
+        connection_cache::ConnectionCache, tpu_client::TpuClientWrapper,
         tpu_connection::TpuConnection,
     },
     solana_core::repair::serve_repair::{RepairProtocol, RepairRequestHeader, ServeRepair},
@@ -829,6 +828,7 @@ pub mod test {
         solana_quic_client::{QuicConfig, QuicConnectionManager, QuicPool},
         solana_rpc::rpc::JsonRpcConfig,
         solana_sdk::timing::timestamp,
+        solana_tpu_client::tpu_client::TpuClientConfig,
     };
 
     const TEST_SEND_BATCH_SIZE: usize = 1;

gossip/src/legacy_contact_info.rs

@@ -327,24 +327,6 @@ mod tests {
         assert!(ci.serve_repair.ip().is_unspecified());
     }
 
-    #[test]
-    fn test_valid_client_facing() {
-        let mut ci = LegacyContactInfo::default();
-        assert_eq!(
-            ci.valid_client_facing_addr(Protocol::QUIC, &SocketAddrSpace::Unspecified),
-            None
-        );
-        ci.tpu = socketaddr!(Ipv4Addr::LOCALHOST, 123);
-        assert_eq!(
-            ci.valid_client_facing_addr(Protocol::QUIC, &SocketAddrSpace::Unspecified),
-            None
-        );
-        ci.rpc = socketaddr!(Ipv4Addr::LOCALHOST, 234);
-        assert!(ci
-            .valid_client_facing_addr(Protocol::QUIC, &SocketAddrSpace::Unspecified)
-            .is_some());
-    }
-
     #[test]
     fn test_sanitize() {
         let mut ci = LegacyContactInfo::default();