Use tokio directly instead of jsonrpc_server_utils's re-export #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh nice. That was probably a holdover from when we had to support two versions of tokio 🤕 |
Seems probable ha. That being said, we can likely rip out the dependence on that crate altogether; looks like only other place and it is also reimporting something from tokio |
Clarification on this statement added to the summary up top but - We no longer import & use the crate directly, altho we still use the crate indirectly through some of our deps |
CriesofCarrots
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Import objects from tokio directly instead of relying on the re-export from
jsonrpc_server_utils:https://docs.rs/jsonrpc-server-utils/latest/jsonrpc_server_utils/#reexports
We no longer import & use the crate directly, altho we still use the crate indirectly through some of our deps