cli::tests: program: Clarify all unwrap_err().
#1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-bobyr
force-pushed
the
pr/cli-tests-clarify-unwrap_err
branch
from
682333f to
b753b72
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1166 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 886 886
Lines 236394 236389 -5
=========================================
- Hits 194205 194180 -25
- Misses 42189 42209 +20 |
`unwrap_err()` does not contain a descriptive message for the case when it succeeds. It may help someone debugging the test, in particular they will see a short explanation without looking at the failed test. Also, in a number of cases, `unwrap_err()` result was not checked, creating a possibility for false positives. As the generated error might be different from the one expected by the test author.
ilya-bobyr
force-pushed
the
pr/cli-tests-clarify-unwrap_err
branch
from
b753b72 to
514bac5
Compare
CriesofCarrots
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unwrap_err()does not contain a descriptive message for the case when it succeeds. It may help someone debugging the test, in particular they will see a short explanation without looking at the failed test.Also, in a number of cases,
unwrap_err()result was not checked, creating a possibility for false positives. As the generated error might be different from the one expected by the test author.This PR includes #1165, I will rebase it after #1165 is merged.
Please, consider only the second commit.