Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes atomic-ness from AccountStorageEntry id and slot fields #119

Conversation

brooksprumo
Copy link

@brooksprumo brooksprumo commented Mar 6, 2024

Problem

As of #118, the id and slot fields in AccountStorageEntry no longer need to be atomic.

Summary of Changes

Removes atomic-ness from AccountStorageEntry id and slot fields

@brooksprumo brooksprumo self-assigned this Mar 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.8%. Comparing base (c161351) to head (98a70e7).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #119     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         838      838             
  Lines      225947   225696    -251     
=========================================
- Hits       184971   184718    -253     
- Misses      40976    40978      +2     

@brooksprumo brooksprumo force-pushed the recycle/account-storage-entry/no-atomic branch from 98a70e7 to 091e315 Compare March 11, 2024 19:41
@brooksprumo brooksprumo marked this pull request as ready for review March 11, 2024 20:41
Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit 1a085c8 into anza-xyz:master Mar 11, 2024
35 checks passed
@brooksprumo brooksprumo deleted the recycle/account-storage-entry/no-atomic branch March 11, 2024 21:09
codebender828 pushed a commit to codebender828/agave that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants