-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version bump v2.0.0 #121
Version bump v2.0.0 #121
Conversation
5ccfa7c
to
37254ce
Compare
37254ce
to
19caee7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 838 838
Lines 226223 226223
=========================================
- Hits 185240 185231 -9
- Misses 40983 40992 +9 |
19caee7
to
eed3136
Compare
\o/ green downstream spl and anchor jobs! |
eed3136
to
c905caa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thanks for fighting through CI to get this all working
solana-sdk = { path = "../../sdk", version = "=2.0.0" } | ||
solana-svm = { path = "../../svm", version = "=2.0.0" } | ||
solana-transaction-status = { path = "../../transaction-status", version = "=2.0.0" } | ||
agave-validator = { path = "../../validator", version = "=2.0.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nittiest-possible-nit: this breaks alphabetical ordering, but it might make more sense to keep it in the same cluster as all the monorepo crates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with either ordering, but if we decide to change it let's do it in another PR. Syncing commits back to the Labs monorepo is much simpler that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
* Put solana-svm in alphabetical order * Update version to 2.0.0. --------- Co-authored-by: Will Hickey <[email protected]>
Summary of Changes
Replicates solana-labs#35154, with some conflict resolution around agave names and svm declaration in
programs/sbf/Cargo.toml