Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump v2.0.0 #121

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

CriesofCarrots
Copy link

Summary of Changes

Replicates solana-labs#35154, with some conflict resolution around agave names and svm declaration in programs/sbf/Cargo.toml

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (85cfe23) to head (c905caa).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #121     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         838      838             
  Lines      226223   226223             
=========================================
- Hits       185240   185231      -9     
- Misses      40983    40992      +9     

@CriesofCarrots
Copy link
Author

CriesofCarrots commented Mar 7, 2024

\o/ green downstream spl and anchor jobs!

@CriesofCarrots CriesofCarrots marked this pull request as ready for review March 7, 2024 17:02
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for fighting through CI to get this all working

solana-sdk = { path = "../../sdk", version = "=2.0.0" }
solana-svm = { path = "../../svm", version = "=2.0.0" }
solana-transaction-status = { path = "../../transaction-status", version = "=2.0.0" }
agave-validator = { path = "../../validator", version = "=2.0.0" }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nittiest-possible-nit: this breaks alphabetical ordering, but it might make more sense to keep it in the same cluster as all the monorepo crates

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with either ordering, but if we decide to change it let's do it in another PR. Syncing commits back to the Labs monorepo is much simpler that way.

Copy link

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@CriesofCarrots CriesofCarrots merged commit 53e7b9a into anza-xyz:master Mar 11, 2024
47 checks passed
codebender828 pushed a commit to codebender828/agave that referenced this pull request Oct 3, 2024
* Put solana-svm in alphabetical order

* Update version to 2.0.0.

---------

Co-authored-by: Will Hickey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants