Gather recording booleans in a data structure #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
force-pushed
the
gather-args
branch
2 times, most recently
from
f53f26e to
ab94be9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 838 838
Lines 225947 225955 +8
=======================================
+ Hits 184923 184933 +10
+ Misses 41024 41022 -2 |
LucasSte
changed the title
dmakarov
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The transaction processing functions utilize three booleans to enable recordings that are passed down as arguments to many functions in a chain. This clutters the code and hinders the easy usage of the SVM.
Summary of Changes
I crated a data structure to contain the three booleans.