Move AccountsDb replication arguments to deprecated list #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These arguments are not read by anything, and they appear to correspond to a proposed feature that is no longer in the codebase.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
=======================================
Coverage 81.8% 81.9%
=======================================
Files 838 838
Lines 226564 226550 -14
=======================================
+ Hits 185522 185547 +25
+ Misses 41042 41003 -39 |
CriesofCarrots
approved these changes
Mar 11, 2024
codebender828
pushed a commit
to codebender828/agave
that referenced
this pull request
Oct 3, 2024
These arguments are not read by anything, and they appear to correspond to a proposed feature that is no longer in the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
These arguments are not read by anything, and they appear to correspond to a proposed feature that is no longer in the codebase.
Summary of Changes
Move deprecated args to deprecated list to get them out of the way. Maybe we can dump a lot of these if we do
2.0release in the near futureDone as cleanup related to #105