Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes redundant imports #193

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

brooksprumo
Copy link

Problem

clippy nightly throws new lints for redundant imports. For example:

warning: the item `Read` is imported redundantly
 --> programs/bpf_loader/gen-syscall-list/build.rs:5:37
  |
5 |         io::{prelude::*, BufWriter, Read},
  |              ----------             ^^^^
  |              |
  |              the item `Read` is already imported here
  |
  = note: `#[warn(unused_imports)]` on by default

Summary of Changes

Remove 'em.

@brooksprumo brooksprumo self-assigned this Mar 11, 2024
@brooksprumo brooksprumo marked this pull request as ready for review March 11, 2024 22:15
@brooksprumo brooksprumo requested a review from yihau March 11, 2024 22:15
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.9%. Comparing base (e027a8b) to head (13ac3e1).
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #193    +/-   ##
========================================
  Coverage    81.8%    81.9%            
========================================
  Files         838      837     -1     
  Lines      226389   226502   +113     
========================================
+ Hits       185342   185548   +206     
+ Misses      41047    40954    -93     

@yihau yihau merged commit aaf3a91 into anza-xyz:master Mar 12, 2024
45 checks passed
@brooksprumo brooksprumo deleted the clippy/redundant branch March 12, 2024 11:46
codebender828 pushed a commit to codebender828/agave that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants