-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract rpc-filter crate #2097
Extract rpc-filter crate #2097
Conversation
If this PR represents a change to the public RPC API:
Thank you for keeping the RPC clients in sync with the server API @kevinheavey. |
441d742
to
f0b642b
Compare
Sorry, I'm going to need more detail on the problem: by what metric is |
A release build takes 70 seconds on my machine and pulls in a long list of heavy dependencies that many use cases don't require, such as spl-token-2022, solana-transaction-status, solana-program-runtime, solana-zk-token-sdk and reqwest |
Sorry, I think I'm going to need to see the bigger picture before jumping on board with this PR or #2084 |
Ah the bigger picture is that rpc_client_api::config is also big enough to be more than one crate - it exposes a bunch of structs that 99% of use cases don't need. But I'd be open to starting by just making a crate that houses both config.rs and filter.rs |
f0b642b
to
0d032c8
Compare
0d032c8
to
06f00c9
Compare
Closing in favour of #4038 |
Problem
solana-rpc-client-api is too big and filter.rs is easy to pull out
Summary of Changes
pull it out and re-export with a deprecation notice