Extract precompile-error crate #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
precompile-error-crate
branch
2 times, most recently
from
5b42e9b to
26a8c80
Compare
kevinheavey
force-pushed
the
precompile-error-crate
branch
from
d5d147a to
a559cfb
Compare
kevinheavey
force-pushed
the
precompile-error-crate
branch
4 times, most recently
from
df21708 to
82a0067
Compare
kevinheavey
force-pushed
the
precompile-error-crate
branch
2 times, most recently
from
b9cb41a to
592b987
Compare
|
Looks good! One minor nit – I think we need to update the import here to use the new crate: https://github.com/anza-xyz/agave/blob/master/programs/ed25519-tests/tests/process_transaction.rs#L8 I will wait for the crate so we can get all checks passing before approving – cc: @yihau. |
Yeah there are several places where the import should be updated but I prefer to do that separately otherwise this PR will get very big |
kevinheavey
force-pushed
the
precompile-error-crate
branch
2 times, most recently
from
1ee08fe to
e573787
Compare
|
@kevinheavey I think we only need to rebase and it should be good to go. |
kevinheavey
force-pushed
the
precompile-error-crate
branch
from
e573787 to
02fcb27
Compare
kevinheavey
force-pushed
the
precompile-error-crate
branch
from
02fcb27 to
73a73c2
Compare
kevinheavey
added
the
automerge
febo
approved these changes
Oct 16, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* extract precompile-error crate * update PrecompileError usage * remove thiserror from precompile-error crate * fmt * remove num-derive * fix imports after rebase * sort deps * sort deps * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Pulling out a
solana_sdk::transactioncrate requires pulling outsolana_sdk::precompileswhich requires pulling outsolana_sdk::ed25519_instruction. Buted25519_instructiondepends on thePrecompileErrortype fromsolana_sdk::precompiles, soPrecompileErrorneeds to be pulled out to avoid a circular dependencySummary of Changes
PrecompileErrorto its own cratethiserrorfrom the new cratePrecompileErrorusage in this repo