Allow configuration of replay thread pools from CLI #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steviez
commented
Mar 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 837 838 +1
Lines 226874 226913 +39
=========================================
- Hits 185870 185862 -8
- Misses 41004 41051 +47 |
bw-solana
reviewed
Mar 14, 2024
t-nelson
reviewed
Mar 15, 2024
steviez
force-pushed
the
cli_replay_threads
branch
from
3887be2 to
f117926
Compare
steviez
force-pushed
the
cli_replay_threads
branch
from
f117926 to
1f5bac4
Compare
|
Force pushed to rebase on tip of master to resolve a conflict |
The trait will reduce redundant code and further enforce these args all being uniform with each other, both in the source code and on the CLI at runtime
codebender828
pushed a commit
to codebender828/agave
that referenced
this pull request
Oct 3, 2024
Bubble up the constants to the CLI that control the sizes of the following two thread pools: - The thread pool used to replay multiple forks in parallel - The thread pool used to execute transactions in parallel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to be able to control threadpool sizes on the CLI - see #105 for more context
Summary of Changes
--replay-slots-concurrentlywhich was a boolean with hard-coded number of threads iftrue)--replay-slots-concurrentlyargumentI did a sanity check real quick to make sure nothing broke on CLI. Namely,
--replay-slots-concurrentlyand--replay-forks-threadsand observed error for conflict as expectedLastly, there is another somewhat related pool that we may wish to control, the one used to replay local ledger before
ReplayStageis created. While that is related, I think we can push to another PR, especially since we'll want an accompanying argument added to ledger-tool as well.