Remove loop from elapsed slots calculation #2393
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A loop that calculates the number of elapsed slots between two epochs depend on the difference between the start and the end epoch:
agave/sdk/src/rent_collector.rs
Line 93 in bb70670
This loop can get quite slow (>20 minutes) if the difference between them is too large.
Summary of Changes
Remove the loop and perform a constant calculation.
I wrote a big comment explaining where I got the expressions from. The math behind it is quite involved, so I included a sanity and a fuzzy test.