Extract program-error crate #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
extract-program-error
branch
from
d8edd16 to
d053b39
Compare
|
The Firedancer team maintains a line-for-line reimplementation of the |
kevinheavey
force-pushed
the
extract-program-error
branch
2 times, most recently
from
af4f8ac to
f693775
Compare
kevinheavey
force-pushed
the
extract-program-error
branch
from
f693775 to
d6accd8
Compare
joncinque
reviewed
Sep 13, 2024
| @@ -5,22 +5,20 @@ | |||
| //! [`bpf_loader`]: crate::bpf_loader | |||
|
|
|||
| extern crate alloc; | |||
| pub use solana_program_error::ProgramResult; | |||
There was a problem hiding this comment.
I agree with your approach of not making this no-std -- if we ever want to do it, we can introduce a breaking change later.
Co-authored-by: Jon C <[email protected]>
|
|
kevinheavey
added
the
automerge
joncinque
approved these changes
Sep 16, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* extract program-error crate * remove `default-features = false` that doesn't do anything * make serde optional in program-error crate * update lock file * remove thiserror from program-error crate * update lock file * move ProgramResult definition to program-error crate * unused import * fix features * missing whitespace Co-authored-by: Jon C <[email protected]> --------- Co-authored-by: Jon C <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana_program::program_errorneeds to be made available outside solana-programThis branches off #2405 so that needs to be merged first.
Summary of Changes