feat: move precompile verification to SVM #2441
Conversation
jstarry
added
the
feature-gate
jstarry
force-pushed
the
feat/move-precompile-verification
branch
from
4eeb6f6 to
2ffc4bf
Compare
| let instruction_datas: Vec<_> = message_instruction_datas_iter.collect(); | ||
| precompile | ||
| .verify(precompile_instruction_data, &instruction_datas, feature_set) | ||
| .map_err(InstructionError::from) |
There was a problem hiding this comment.
The new primitive traits are needed to convert to/from InstructionError::Custom and the ToPrimitive trait is specifically used here.
See this implementation for details:
impl<T> From<T> for InstructionError
where
T: ToPrimitive,
|
@Lichtso could you please check the message processor and invoke context changes? |
|
Instead of using |
|
No I think it's more appropriate to use custom errors here because these errors aren't general, they are program specific. Can you explain why adding new instruction error variants would make more sense? |
|
I might have missed it, but the changes in errors are not mentioned in the features SIMD, or are they? |
No they are not but they probably should, thanks for bringing that up. There really isn't a good precedent for precompile error handling since we generally disregard any errors for dropped transactions. Currently we map precompile errors to I will update the SIMD with details about the errors and have them mapped to |
| assert_matches!( | ||
| client.process_transaction(transaction).await, | ||
| Err(BanksClientError::TransactionError( | ||
| TransactionError::InvalidAccountIndex | ||
| TransactionError::InstructionError(0, InstructionError::Custom(3)) | ||
| )) | ||
| ); | ||
| // this assert is for documenting the matched error code above |
|
think we ought to push on the SIMD as well, but may not have luck merging until after breakpoint |
Problem
Transactions with precompile signatures that fail verification are currently not allowed to be committed to a block. After solana-foundation/solana-improvement-documents#159 they will be allowed to be committed so that block producers always get paid fees when verifying precompile signatures.
Summary of Changes
Fixes #