Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18: Bump platform tools version to v1.42 (backport of #2355) #2460

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 6, 2024

Problem

Platform tools version v1.41 misses many stack errors and does not provide a good experience to developers. It still miscomplies contracts with propers warnings about their possible misbehavior during execution.

Summary of Changes

These problems have been fixed in the new platform tools version. It does not yet bring Rust 1.79, but it has several improvements in terms of the stack limitation in SBF.

I also updated the links in carg-build-sbf to anza-xyz.


This is an automatic backport of pull request #2355 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner August 6, 2024 17:12
@LucasSte
Copy link

LucasSte commented Aug 6, 2024

The existing platform-tools misses errors about stack overflow and stack overwrite. In this case, developers can compile a contract without any error, but it either throw an access violation error or misbehave with data corruption. I'm back porting the release to remediate this problem.

Refer to issues #1186, #1158.

@LucasSte LucasSte requested a review from dmakarov August 6, 2024 17:17
@andreisilviudragnea
Copy link

andreisilviudragnea commented Aug 20, 2024

@dmakarov @LucasSte Why is this still not merged? I had issues with silent stack size violations on Solana v1.18.21 too.

@LucasSte
Copy link

@dmakarov @LucasSte Why is this still not merged? I had issues with silent stack size violations on Solana v1.18.21 too.

@andreisilviudragnea Consider updating to Agave v2.0. I already contains the update.

@LucasSte LucasSte closed this Sep 2, 2024
@mergify mergify bot deleted the mergify/bp/v1.18/pr-2355 branch September 2, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants