hash-cache-tool: Adds command to diff state #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
hash-cache-tool/diff-state/impl
branch
from
a3d6cb3 to
9ac7447
Compare
HaoranYi
reviewed
Aug 9, 2024
| .takes_value(true) | ||
| .value_name("PATH2") | ||
| .help("Accounts hash cache directory 2 to diff"), | ||
| ), |
There was a problem hiding this comment.
Maybe add an optional sub-arg for bin-range to extract?
default to all bin-range.
There was a problem hiding this comment.
Yeah that should be possible. Can that be a follow up PR? Can also add a cli arg for the number of bins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The hash cache tool cannot diff the final state of the accounts hash cache directories.
Summary of Changes
Adds command to diff state.