Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0: checks for duplicate instances using the new ContactInfo (backport of #2506) #2510

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 8, 2024

Problem

Working towards deprecating NodeInstance CRDS value and replacing that with the new ContactInfo.

Summary of Changes

Check for duplicate instances using the new ContactInfo.


This is an automatic backport of pull request #2506 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner August 8, 2024 21:04
@behzadnouri behzadnouri requested a review from gregcusack August 8, 2024 23:09
@behzadnouri
Copy link

New ContactInfo is already shipped in v2.0.
This part of logic has been missing and it is necessary for full migration and deprecating NodeInstance.

@behzadnouri behzadnouri added the automerge automerge Merge this Pull Request automatically once CI passes label Aug 8, 2024
@anza-team
Copy link
Collaborator

😱 New commits were pushed while the automerge label was present.

@anza-team anza-team removed the automerge automerge Merge this Pull Request automatically once CI passes label Aug 9, 2024
@behzadnouri behzadnouri force-pushed the mergify/bp/v2.0/pr-2506 branch 2 times, most recently from 23d96e2 to 25f5415 Compare August 9, 2024 14:22
Working towards deprecating NodeInstance CRDS value, the commit adds
check for duplicate instances using the new ContactInfo.

(cherry picked from commit 1d825df)
@behzadnouri behzadnouri force-pushed the mergify/bp/v2.0/pr-2506 branch from 25f5415 to ad8aed3 Compare August 9, 2024 17:31
Copy link

@gregcusack gregcusack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@behzadnouri behzadnouri added the automerge automerge Merge this Pull Request automatically once CI passes label Aug 14, 2024
@mergify mergify bot merged commit f615f41 into v2.0 Aug 14, 2024
40 checks passed
@mergify mergify bot deleted the mergify/bp/v2.0/pr-2506 branch August 14, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants