v2.0: EpochRewards: decode points and rewards fields as Strings (backport of #2501) #2512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
EpochRewards::points
can easily overflow the max JSON integer, but we are trying to useserde_json::Number
insolana-account-decoder
: #760This results in RPC results that fail JSON parsing, eg:
Summary of Changes
Decode
points
,distributedRewards
, andtotalRewards
as stringsnumPartitions
should never overflow as it is capped at 43,200startingBlockHeight
could overflow some day, but there are lots of other decoders passing Slot as a number, so this is a more systemic problem and can/should be addressed in one fell swoop.This is an automatic backport of pull request #2501 done by [Mergify](https://mergify.com).