hash-cache-tool: Adds cli arg to limit state to single bin #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoranYi
reviewed
Aug 12, 2024
| @@ -143,6 +144,20 @@ fn main() { | |||
| Must be a power of two, greater than 0, \ | |||
| and less-than-or-equal-to 16,777,216 (2^24)" | |||
| ), | |||
| ) | |||
| .arg( | |||
| Arg::with_name("bin_of_interest") | |||
There was a problem hiding this comment.
This works.
I wonder if we could relax the single-bin to a bin-range?
For 8192 bins, we would need to run the command and scan the cache 8192 times to check all bins.
There was a problem hiding this comment.
Yep definitely. I was going incrementally first.
HaoranYi
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Using the hash cache tool to diff state on pop-net with billions of accounts, we'll run out of memory trying to hold all that state.
Summary of Changes
Add a cli arg,
--bin-of-interest, to limit the state we hold to a single bin.