refactor: new load_transaction_account function #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
refactor/load-transaction-account
branch
from
c2d44d9 to
baa96d1
Compare
apfitzge
reviewed
Aug 14, 2024
svm/src/account_loader.rs
Outdated
| }; | ||
|
|
||
| collect_account(key, account_size, account, rent, account_found)?; | ||
| let loaded_account = load_transaction_account( |
There was a problem hiding this comment.
It seems a odd for this to take account_found as a mutable instead of returning a tuple (loaded_account, account_found). If I'm missing some context on the choice lmk.
There was a problem hiding this comment.
Hmm not sure why I decided to that, switching to return a tuple as you suggested.
apfitzge
approved these changes
Aug 14, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fn load_transaction_accountsis too big and takes too many argumentsSummary of Changes
load_transaction_accountfunctionLoadedTransactionAccountstruct for representing loaded account detailsFixes #