TransactionView: InstructionsIterator #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
commented
Aug 13, 2024
| /// # Safety | ||
| /// - This function must be called with the same `bytes` slice that was | ||
| /// used to create the `TransactionMeta` instance. | ||
| pub unsafe fn instructions_iter<'a>(&self, bytes: &'a [u8]) -> InstructionsIterator<'a> { |
There was a problem hiding this comment.
Was on the fence about whether this should return the actual type or just an impl Iterator/ExactSizeIterator.
Anyone got strong feelings on this one way or another?
apfitzge
force-pushed
the
instructions_iterator
branch
from
91f64d2 to
7ae6f37
Compare
LucasSte
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
instructions_itertoTransactionMetato allow iterating over instructionsFixes #